[qttools] fix qdbusviewer#29153
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Jan 27, 2023
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Neumann-A
reviewed
Jan 24, 2023
Neumann-A
reviewed
Jan 24, 2023
Neumann-A
reviewed
Jan 24, 2023
Member
|
I would like @Neumann-A to affirm that he is happy with any changes to qt's guts before merging. |
Neumann-A
reviewed
Jan 25, 2023
Neumann-A
suggested changes
Jan 25, 2023
Contributor
Neumann-A
left a comment
Neumann-A
left a comment
There was a problem hiding this comment.
the little list change and then it should be ok.
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for qttools have changed but the version was not updated
version: 6.4.2#1
old SHA: dd8156b0557baf6484f68e7f1181f80aa6832ca1
new SHA: 0dc19ef06a3e54a475cedeacd80987aea5ac4477
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Member
|
Thanks for the fix @cnSchwarzer and thanks for the review @Neumann-A ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix building
qttoolson macOS that previously the portfile will try to copyqdbusviewer.app, but if theqtbase[dbus]is not installed, this tool will not be built, result in a build failure (copy and file not found).By investigating Windows build, the
qdbusviewer.exeis also missing ifqtbase[dbus]is not enabled. So this port is "mis-compiling"qdbusviewerat all, probably because previous maintainer just enabledqtbase[dbus]in other dependency and consideringqdbusvieweris built byqttoolsas a default (which is not).Regarding that, create a new feature
qttools[qdbusviewer]to addqtbase[dbus]as a dependency and better control of this build behaviour, and conditionally copyqdbusviewer.appif it is actually built.